[Draft] | GPUAI-3720 - Integrate Universal GEMM into Grouped GEMM - Pt 1 #1800
+971
−438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtmadduri
force-pushed
the
rimadduri/universal_gemm_into_grouped_gemm
branch
from
469a083 to
15a21fc
Compare
aosewski
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Good work. But still a bunch of things to do. Keep in mind that CDataType is equivalent of EDataType there's no need to duplicate just pickup one - rather EDataType.
Additionally don't forget to check all neccessary conditions for all gemms and infer from them value that holds for all gemms, like all_have_kbatch_gt_one or all_have_main_kblock_loop this must be checked for all gemms.
Additionally you'd have to calculate tail_number and verify if it's same for all gemms.
include/ck/tensor_operation/gpu/device/impl/device_grouped_gemm_xdl_splitk_cshuffle.hpp
Outdated
Show resolved
Hide resolved
include/ck/tensor_operation/gpu/device/impl/device_grouped_gemm_xdl_splitk_cshuffle.hpp
Outdated
Show resolved
Hide resolved
include/ck/tensor_operation/gpu/device/impl/device_grouped_gemm_xdl_splitk_cshuffle.hpp
Outdated
Show resolved
Hide resolved
include/ck/tensor_operation/gpu/device/impl/device_grouped_gemm_xdl_splitk_cshuffle.hpp
Outdated
Show resolved
Hide resolved
include/ck/tensor_operation/gpu/device/impl/device_grouped_gemm_xdl_splitk_cshuffle.hpp
Outdated
Show resolved
Hide resolved
include/ck/tensor_operation/gpu/device/impl/device_grouped_gemm_xdl_splitk_cshuffle.hpp
Outdated
Show resolved
Hide resolved
include/ck/tensor_operation/gpu/device/impl/device_grouped_gemm_xdl_splitk_cshuffle.hpp
Outdated
Show resolved
Hide resolved
include/ck/tensor_operation/gpu/device/impl/device_grouped_gemm_xdl_splitk_cshuffle.hpp
Outdated
Show resolved
Hide resolved
rtmadduri
force-pushed
the
rimadduri/universal_gemm_into_grouped_gemm
branch
from
4eea3bd to
a6f99d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR integrates Universal GEMM into Device Grouped Gemm.
Specifically, we replace:
The GridwiseGemm_bk0mk1_bk0nk1_mn_xdlops_v2r4r2 in device_grouped_gemm_xdl_splitk_cshuffle.hpp with GridwiseGemm_xdl_cshuffle_v3
We make corresponding changes to the struct Argument and struct Invoke
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered